Introduce OCI artifacts signatures #296
Conversation
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
changed the title
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
feat/registry-print-status
branch
from
ee5ac2a to
ee8b2b3
Compare
maxgio92
changed the title
|
Ready to be reviewed @falcosecurity/plugins-maintainers |
| if: ${{ needs.publish-oci-artifacts.outputs.matrix != '[]' }} | ||
| strategy: | ||
| matrix: | ||
| value: ${{ fromJson(needs.publish-oci-artifacts.outputs.matrix) }} |
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
maxgio92
force-pushed
the
feat/registry-print-status
branch
from
6811d57 to
1f4e1f5
Compare
|
I was able to test artifacts produced with this workflow along with my falcoctl patch linked in this PR and it works! :) |
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
| return err | ||
| pa, ra, err := handleArtifact(ctx, cfg, &plugin, s3Client, ociClient) | ||
| if err != nil { | ||
| return artifacts, err |
There was a problem hiding this comment.
Should we return nil? Do we use partial results in case of error?
There was a problem hiding this comment.
Thanks, @alacuku, I think it would be useful to provide them, as at the end of the day, the previous successful handle runs, if any, would be successful. WDYT?
| // Clean up | ||
| if err := os.RemoveAll(plugin.Name); err != nil { | ||
| return fmt.Errorf("unable to remove folder %q: %v", plugin.Name, err) | ||
| return artifacts, fmt.Errorf("unable to remove folder %q: %v", plugin.Name, err) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr, maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area registry
/area build
What this PR does / why we need it:
To provide signatures for the plugin OCI artifacts, as OCI artifacts, with cosign.
Which issue(s) this PR fixes:
Fixes #244
Special notes for your reviewer:
This is part of the work for providing signatures for Falco artifacts, alongside: